webrtc/common_video/video_frame.cc - Issue 1306813009: H.264 video codec support using OpenH264/FFmpeg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/video_frame.cc

Issue 1306813009: H.264 video codec support using OpenH264/FFmpeg (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: (Alphabetical sorting in common_video.gyp deps) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_video/video_frame.cc

diff --git a/webrtc/common_video/video_frame.cc b/webrtc/common_video/video_frame.cc

index 3bf59a720cde8b9b19ed75ce52d64e5ca61e1367..86de823dc964be85c5c7e24fb835ff8de62828b6 100644

--- a/webrtc/common_video/video_frame.cc

+++ b/webrtc/common_video/video_frame.cc

@@ -19,9 +19,9 @@

namespace webrtc {

-// TODO(hbos): The FFmpeg video decoder will require up to 8 bytes, update this

-// when the FFmpeg decoder is added.

-const size_t EncodedImage::kBufferPaddingBytesH264 = 0;

+// FFmpeg's decoder, used by H264DecoderImpl, requires up to 8 bytes padding due

+// to optimized bitstream readers. See avcodec_decode_video2.

+const size_t EncodedImage::kBufferPaddingBytesH264 = 8;

bool EqualPlane(const uint8_t* data1,

const uint8_t* data2,

« no previous file with comments | « webrtc/common_video/common_video.gyp ('k') | webrtc/modules/modules.gyp » ('j') | no next file with comments »