Send vsync notification from browser to renderer

content/renderer/gpu/compositor_output_surface.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/compositor_output_surface.h"
 
 #include "base/command_line.h"
 #include "base/message_loop_proxy.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/compositor_frame_ack.h"
@@ skipping 24 matching lines @@
 namespace content {
 
 //------------------------------------------------------------------------------
 
 // static
 IPC::ForwardingMessageFilter* CompositorOutputSurface::CreateFilter(
     base::TaskRunner* target_task_runner)
 {
   uint32 messages_to_filter[] = {
     ViewMsg_UpdateVSyncParameters::ID,
+    ViewMsg_DidVSync::ID,
     ViewMsg_SwapCompositorFrameAck::ID
   };
 
   return new IPC::ForwardingMessageFilter(
       messages_to_filter, arraysize(messages_to_filter),
       target_task_runner);
 }
 
 CompositorOutputSurface::CompositorOutputSurface(
     int32 routing_id,
@@ skipping 44 matching lines @@
   DCHECK(CalledOnValidThread());
   Send(new ViewHostMsg_SwapCompositorFrame(routing_id_, *frame));
 }
 
 void CompositorOutputSurface::OnMessageReceived(const IPC::Message& message) {
   DCHECK(CalledOnValidThread());
   if (!client_)
     return;
   IPC_BEGIN_MESSAGE_MAP(CompositorOutputSurface, message)
     IPC_MESSAGE_HANDLER(ViewMsg_UpdateVSyncParameters, OnUpdateVSyncParameters);
+    IPC_MESSAGE_HANDLER(ViewMsg_DidVSync, DidVSync);
     IPC_MESSAGE_HANDLER(ViewMsg_SwapCompositorFrameAck, OnSwapAck);
   IPC_END_MESSAGE_MAP()
 }
 
 void CompositorOutputSurface::OnUpdateVSyncParameters(
     base::TimeTicks timebase, base::TimeDelta interval) {
   DCHECK(CalledOnValidThread());
   DCHECK(client_);
   client_->OnVSyncParametersChanged(timebase, interval);
 }
 
+void CompositorOutputSurface::EnableVSyncNotification(bool enable) {
+  DCHECK(CalledOnValidThread());
+  DCHECK(client_);

[jam, 2013/03/27 16:13:06]

nit: this dcheck, and the similar one below, is redundant. in release builds, it
does nothing. in debug builds, the next line would crash which is just as strong
of a signal to the developer that there's a null dereference

[Sami, 2013/03/27 17:38:06]

Good point, I'll remove this and the other similar checks in this file. This
specific function didn't even use client_ so the check was doubly redundant.

+  Send(new ViewHostMsg_SetVSyncNotificationEnabled(routing_id_, enable));
+}
+
+void CompositorOutputSurface::DidVSync(base::TimeTicks frame_time) {
+  DCHECK(CalledOnValidThread());
+  DCHECK(client_);
+  client_->DidVSync(frame_time);
+}
+
 void CompositorOutputSurface::OnSwapAck(const cc::CompositorFrameAck& ack) {
   client_->OnSendFrameToParentCompositorAck(ack);
 }
 
 bool CompositorOutputSurface::Send(IPC::Message* message) {
   return ChildThread::current()->sync_message_filter()->Send(message);
 }
 
 namespace {
 #if defined(OS_ANDROID)
@@ skipping 31 matching lines @@
   // If this is the last surface to stop preferring smoothness,
   // Reset the main thread's priority to the default.
   if (prefers_smoothness_ == true &&
       --g_prefer_smoothness_count == 0) {
     SetThreadsPriorityToDefault(main_thread_id_);
   }
   prefers_smoothness_ = prefers_smoothness;
 }
 
 }  // namespace content