Fix infinite loop for objects that reference themselves.

Fix infinite loop for objects that reference themselves.

BUG=pdfium:193
R=jun_fang@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/0c9f1d8f6dd6bb8b9c3eba73e4ffd0bb2ca4fd97

[Lei Zhang, 2015-08-21 06:16:34]

thestig@chromium.org changed reviewers:
+ jun_fang@foxitsoftware.com

[Lei Zhang, 2015-08-21 06:21:32]

As noted on the bug, this just fixed the PDF in the bug. There's still lots of
ways to get into an infinite loop with CPDF_Object.

[jun_fang, 2015-08-21 21:44:36]

On 2015/08/21 06:21:32, Lei Zhang wrote:
> As noted on the bug, this just fixed the PDF in the bug. There's still lots of
> ways to get into an infinite loop with CPDF_Object.

Only one nit. LGTM.

[jun_fang, 2015-08-21 21:44:43]

https://codereview.chromium.org/1306793002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1306793002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:149: CPDF_Object* pObj =
pIndirect->GetIndirectObject(pRef->m_RefObjNum);
nit: call pRef->GetRefObjNum to get object number to replace pRef->m_RefObjNum.
It's the same rule as pRef->GetObjList().

[Lei Zhang, 2015-08-31 05:45:02]

https://codereview.chromium.org/1306793002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1306793002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:149: CPDF_Object* pObj =
pIndirect->GetIndirectObject(pRef->m_RefObjNum);
On 2015/08/21 21:44:43, jun_fang wrote:
> nit: call pRef->GetRefObjNum to get object number to replace
pRef->m_RefObjNum.
> It's the same rule as pRef->GetObjList().

Done. I made the same change everywhere in the file.

[Lei Zhang, 2015-08-31 05:45:13]

Committed patchset #3 (id:40001) manually as
0c9f1d8f6dd6bb8b9c3eba73e4ffd0bb2ca4fd97 (presubmit successful).