Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4515)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js
index ab938b2d43a3bce07937624f4599a315a7156f56..8fb4fd4eb9530937d4d6023f51a29c03cd3bbd88 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js
@@ -199,7 +199,7 @@ cvox.ApiImplementation.stop = function() {
*/
cvox.ApiImplementation.playEarcon = function(earcon) {
if (cvox.ChromeVox.isActive) {
- cvox.ChromeVox.earcons.playEarconByName(earcon);
+ cvox.ChromeVox.earcons.playEarcon(cvox.Earcon[earcon]);
Peter Lundblad 2015/08/27 19:54:56 Should guard against passing in undefined to this
dmazzoni 2015/08/27 21:27:47 Done.
}
};

Powered by Google App Engine
This is Rietveld 408576698