Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/walkers/table_shifter.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons
Patch Set: Fixed test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/walkers/math_shifter.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Walkers to traverse a table. 6 * @fileoverview Walkers to traverse a table.
7 */ 7 */
8 8
9 9
10 goog.provide('cvox.TableShifter'); 10 goog.provide('cvox.TableShifter');
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 * @override 71 * @override
72 * @suppress {checkTypes} actual parameter 2 of 72 * @suppress {checkTypes} actual parameter 2 of
73 * cvox.Msgs.prototype.getMsg does not match formal parameter 73 * cvox.Msgs.prototype.getMsg does not match formal parameter
74 * found : Array<number> 74 * found : Array<number>
75 * required: (Array<string>|null|undefined) 75 * required: (Array<string>|null|undefined)
76 */ 76 */
77 cvox.TableShifter.prototype.getDescription = function(prevSel, sel) { 77 cvox.TableShifter.prototype.getDescription = function(prevSel, sel) {
78 var descs = this.currentWalker_.getDescription(prevSel, sel); 78 var descs = this.currentWalker_.getDescription(prevSel, sel);
79 if (descs.length > 0) { 79 if (descs.length > 0) {
80 if (this.bumpedEdge_) { 80 if (this.bumpedEdge_) {
81 descs[0].pushEarcon(cvox.AbstractEarcons.WRAP_EDGE); 81 descs[0].pushEarcon(cvox.Earcon.WRAP_EDGE);
82 this.bumpedEdge_ = false; 82 this.bumpedEdge_ = false;
83 } 83 }
84 if (this.begin_) { 84 if (this.begin_) {
85 var len = descs.length; 85 var len = descs.length;
86 var summaryText = this.currentWalker_.tt.summaryText(); 86 var summaryText = this.currentWalker_.tt.summaryText();
87 var locationInfo = this.currentWalker_.getLocationInfo(sel); 87 var locationInfo = this.currentWalker_.getLocationInfo(sel);
88 if (locationInfo != null) { 88 if (locationInfo != null) {
89 descs.push(new cvox.NavDescription({ 89 descs.push(new cvox.NavDescription({
90 context: cvox.ChromeVox.msgs.getMsg('table_location', locationInfo), 90 context: cvox.ChromeVox.msgs.getMsg('table_location', locationInfo),
91 text: '', 91 text: '',
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 * @override 143 * @override
144 */ 144 */
145 cvox.TableShifter.create = function(sel) { 145 cvox.TableShifter.create = function(sel) {
146 var ancestors = cvox.DomUtil.getAncestors(sel.start.node); 146 var ancestors = cvox.DomUtil.getAncestors(sel.start.node);
147 if (cvox.DomPredicates.tablePredicate(ancestors) && 147 if (cvox.DomPredicates.tablePredicate(ancestors) &&
148 !cvox.DomPredicates.captionPredicate(ancestors)) { 148 !cvox.DomPredicates.captionPredicate(ancestors)) {
149 return new cvox.TableShifter(); 149 return new cvox.TableShifter();
150 } 150 }
151 return null; 151 return null;
152 }; 152 };
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/walkers/math_shifter.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698