Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 1306773003: Make earcon ids strings instead of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_unused_earcons
Patch Set: Fixed test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Provides output services for ChromeVox. 6 * @fileoverview Provides output services for ChromeVox.
7 */ 7 */
8 8
9 goog.provide('Output'); 9 goog.provide('Output');
10 goog.provide('Output.EventType'); 10 goog.provide('Output.EventType');
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 Output.Action.call(this); 519 Output.Action.call(this);
520 /** @type {string} */ 520 /** @type {string} */
521 this.earconId = earconId; 521 this.earconId = earconId;
522 }; 522 };
523 523
524 Output.EarconAction.prototype = { 524 Output.EarconAction.prototype = {
525 __proto__: Output.Action.prototype, 525 __proto__: Output.Action.prototype,
526 526
527 /** @override */ 527 /** @override */
528 run: function() { 528 run: function() {
529 cvox.ChromeVox.earcons.playEarcon(cvox.AbstractEarcons[this.earconId]); 529 cvox.ChromeVox.earcons.playEarcon(cvox.Earcon[this.earconId]);
530 } 530 }
531 }; 531 };
532 532
533 /** 533 /**
534 * Annotation for selection. 534 * Annotation for selection.
535 * @param {number} startIndex 535 * @param {number} startIndex
536 * @param {number} endIndex 536 * @param {number} endIndex
537 * @constructor 537 * @constructor
538 */ 538 */
539 Output.SelectionSpan = function(startIndex, endIndex) { 539 Output.SelectionSpan = function(startIndex, endIndex) {
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 elem.end); 1290 elem.end);
1291 }); 1291 });
1292 spansToRemove.forEach(result.removeSpan.bind(result)); 1292 spansToRemove.forEach(result.removeSpan.bind(result));
1293 separator = Output.SPACE; 1293 separator = Output.SPACE;
1294 }); 1294 });
1295 return result; 1295 return result;
1296 } 1296 }
1297 }; 1297 };
1298 1298
1299 }); // goog.scope 1299 }); // goog.scope
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698