Make earcon ids strings instead of numbers.

chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Accesses Chrome's tabs extension API and gives
  * feedback for events that happen in the "Chrome of Chrome".
  */
 
 goog.provide('cvox.TabsApiHandler');
@@ skipping 44 matching lines @@
    */
   onCreated: function(tab) {
     if (!cvox.ChromeVox.isActive) {
       return;
     }
     this.tts_.speak(this.msg_('chrome_tab_created'),
                    cvox.QueueMode.FLUSH,
                    cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
     this.braille_.write(
         cvox.NavBraille.fromText(this.msg_('chrome_tab_created')));
-    this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_OPEN);
+    this.earcons_.playEarcon(cvox.Earcon.OBJECT_OPEN);
   },
 
   /**
    * Handles chrome.tabs.onRemoved.
    * @param {Object} tab
    */
   onRemoved: function(tab) {
     if (!cvox.ChromeVox.isActive) {
       return;
     }
-    this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_CLOSE);
+    this.earcons_.playEarcon(cvox.Earcon.OBJECT_CLOSE);
   },
 
   /**
    * Handles chrome.tabs.onActivated.
    * @param {Object} activeInfo
    */
   onActivated: function(activeInfo) {
     if (!cvox.ChromeVox.isActive) {
       return;
     }
     chrome.tabs.get(activeInfo.tabId, function(tab) {
       this.lastActiveTabLoaded_ = tab.status == 'complete';
       if (tab.status == 'loading') {
         return;
       }
       var title = tab.title ? tab.title : tab.url;
       this.tts_.speak(this.msg_('chrome_tab_selected',
                          [title]),
                      cvox.QueueMode.FLUSH,
                      cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
       this.braille_.write(
           cvox.NavBraille.fromText(this.msg_('chrome_tab_selected', [title])));
-      this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_SELECT);
+      this.earcons_.playEarcon(cvox.Earcon.OBJECT_SELECT);
     }.bind(this));
   },
 
   /**
    * Handles chrome.tabs.onUpdated.
    * @param {number} tabId
    * @param {Object} selectInfo
    */
   onUpdated: function(tabId, selectInfo) {
     if (!cvox.ChromeVox.isActive) {
       return;
     }
     chrome.tabs.get(tabId, function(tab) {
       if (!tab.active) {
         return;
       }
       if (tab.status == 'loading') {
         this.lastActiveTabLoaded_ = false;
-        this.earcons_.playEarcon(cvox.AbstractEarcons.BUSY_PROGRESS_LOOP);
+        this.earcons_.playEarcon(cvox.Earcon.BUSY_PROGRESS_LOOP);
       } else if (!this.lastActiveTabLoaded_) {
         this.lastActiveTabLoaded_ = true;
-        this.earcons_.playEarcon(cvox.AbstractEarcons.TASK_SUCCESS);
+        this.earcons_.playEarcon(cvox.Earcon.TASK_SUCCESS);
       }
     }.bind(this));
   },
 
   /**
    * Handles chrome.windows.onFocusChanged.
    * @param {number} windowId
    */
   onFocusChanged: function(windowId) {
     if (!cvox.ChromeVox.isActive) {
       return;
     }
     if (windowId == chrome.windows.WINDOW_ID_NONE) {
       return;
     }
     chrome.windows.get(windowId, function(window) {
       chrome.tabs.query({active: true, windowId: windowId}, function(tabs) {
         var msgId = window.incognito ? 'chrome_incognito_window_selected' :
             'chrome_normal_window_selected';
         var tab = tabs[0] || {};
         var title = tab.title ? tab.title : tab.url;
         this.tts_.speak(this.msg_(msgId, [title]),
                        cvox.QueueMode.FLUSH,
                        cvox.AbstractTts.PERSONALITY_ANNOUNCEMENT);
         this.braille_.write(
             cvox.NavBraille.fromText(this.msg_(msgId, [title])));
-        this.earcons_.playEarcon(cvox.AbstractEarcons.OBJECT_SELECT);
+        this.earcons_.playEarcon(cvox.Earcon.OBJECT_SELECT);
       }.bind(this));
     }.bind(this));
   }
 };