Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1306753007: Pulling in a gyp fix for wasm. (Closed)

Created:
5 years, 3 months ago by bradn
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pulling in a gyp fix for wasm. BUG= https://github.com/WebAssembly/v8-native-prototype/issues/10 TEST=manual check of wasm=on R=dehrenberg@chromium.org LOG=N Committed: https://crrev.com/0304b29959e898a46271e2df22b7c51a914586b0 Cr-Commit-Position: refs/heads/master@{#30598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bradn
5 years, 3 months ago (2015-09-04 20:02:59 UTC) #1
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-09-04 20:11:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306753007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306753007/1
5 years, 3 months ago (2015-09-04 20:11:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 20:28:13 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 20:28:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0304b29959e898a46271e2df22b7c51a914586b0
Cr-Commit-Position: refs/heads/master@{#30598}

Powered by Google App Engine
This is Rietveld 408576698