Source/core/html/parser/HTMLSrcsetParser.cpp - Issue 1306743003: Fix float parsing in srcset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLSrcsetParser.cpp

Issue 1306743003: Fix float parsing in srcset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: switched clamp to cast Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/parser/HTMLSrcsetParser.cpp

diff --git a/Source/core/html/parser/HTMLSrcsetParser.cpp b/Source/core/html/parser/HTMLSrcsetParser.cpp

index 8283ecd41536a733ce2d23e426c427da4eeffa4c..b9910d859fe997daa7175c2d0744fe8affa8bbc6 100644

--- a/Source/core/html/parser/HTMLSrcsetParser.cpp

+++ b/Source/core/html/parser/HTMLSrcsetParser.cpp

@@ -97,7 +97,11 @@ struct DescriptorToken {

isValid = false;

return 0;

}

- return charactersToFloat(attribute + start, lengthExcludingDescriptor, &isValid);

+ Decimal result = parseToDecimalForNumberType(String(attribute + start, lengthExcludingDescriptor));

+ isValid = result.isFinite();

+ if (!isValid)

+ return 0;

+ return static_cast<float>(result.toDouble());

}

};