Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1306713007: Revert of Implement "Look Up In Dictionary" context menu item asynchronously. (Closed)

Created:
5 years, 3 months ago by Shu Chen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement "Look Up In Dictionary" context menu item asynchronously. (patchset #6 id:100001 of https://codereview.chromium.org/1313553006/ ) Reason for revert: Caused regression crbug.com/528929. Original issue's description: > Implement "Look Up In Dictionary" context menu item asynchronously. (OS X) > > Reduces the number of callers of the synchronous IPC in > TextInputClientMac::GetAttributedSubstringFromRange() (so that eventually we can > remove it). > > BUG=121917 > TEST=Verified "Look Up in Dictionary" by context menu feature works well. > > Committed: https://crrev.com/cabb6815f85f0e6297a55eb313a8e11373e2da9e > Cr-Commit-Position: refs/heads/master@{#347306} TBR=asvitkine@chromium.org,palmer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=121917 Committed: https://crrev.com/a689467ce5c0d4f7f396a40509d40a557533aa0e Cr-Commit-Position: refs/heads/master@{#347649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +4 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm View 1 chunk +28 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Shu Chen
Created Revert of Implement "Look Up In Dictionary" context menu item asynchronously.
5 years, 3 months ago (2015-09-08 00:51:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306713007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306713007/1
5 years, 3 months ago (2015-09-08 00:51:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 00:51:48 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 00:52:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a689467ce5c0d4f7f396a40509d40a557533aa0e
Cr-Commit-Position: refs/heads/master@{#347649}

Powered by Google App Engine
This is Rietveld 408576698