Issue 1306713002: Fix bug in the call to random number generator in Cfg's ctor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1306713002: Fix bug in the call to random number generator in Cfg's ctor (Closed)

Created:
5 years, 4 months ago by qining

Modified:
5 years, 4 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix bug in the call to random number generator in Cfg's ctor BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=360e31978e06a809bf89e4eb834e3c1dc2fbd860

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -29 lines)			Patch
M	src/IceCfg.cpp	View	1 chunk	+2 lines, -4 lines	1 comment	Download
M	tests_lit/llvm2ice_tests/randomize-pool-immediate-basic.ll	View	6 chunks	+22 lines, -22 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/rng.ll	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1306713002/diff/1/src/IceCfg.cpp File src/IceCfg.cpp (right): https://codereview.chromium.org/1306713002/diff/1/src/IceCfg.cpp#newcode50 src/IceCfg.cpp:50: RPE_ConstantBlinding, this->SequenceNumber); I think you can drop the ...

5 years, 4 months ago (2015-08-21 00:12:31 UTC) #3

qining

5 years, 4 months ago (2015-08-21 00:13:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
360e31978e06a809bf89e4eb834e3c1dc2fbd860 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages