Issue 13067002: In ~ExtensionHost, close swapped-out RenderViews referring to this extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13067002: In ~ExtensionHost, close swapped-out RenderViews referring to this extension. (Closed)

Created:
7 years, 9 months ago by Jeffrey Yasskin

Modified:
7 years, 9 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, ivanku, Charlie Reis

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

In ~ExtensionHost, close swapped-out RenderViews referring to this extension. I don't think this is the ideal fix, but it works, and I don't think I can get the real fix debugged by the M27 branch. BUG=178542 TEST=Use the instructions at http://crbug.com/178542#c16 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190543

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/extensions/extension_host.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Matt Perry

Yikes, that's quite a hack. LGTM as long as it doesn't stay in long.

7 years, 9 months ago (2013-03-25 18:34:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/13067002/1

7 years, 9 months ago (2013-03-25 18:42:39 UTC) #3

Jeffrey Yasskin

7 years, 9 months ago (2013-03-26 02:08:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r190543 (presubmit successful).