Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.h

Issue 1306693005: Allow the minimum time between banner trigger visits to be varied via field trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_settings_helper.h
diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h
index c4d3da2e78f23f910e711be7d94f04963096c835..74db0265a30ffdc49904cc2e0141952280a323ef 100644
--- a/chrome/browser/banners/app_banner_settings_helper.h
+++ b/chrome/browser/banners/app_banner_settings_helper.h
@@ -122,6 +122,20 @@ class AppBannerSettingsHelper {
static void SetEngagementWeights(double direct_engagement,
double indirect_engagement);
+ // Set the minimum number of minutes between banner visits that will
+ // trigger a could show banner event. This must be less than the
+ // number of minutes in a day, and evenly divide the number of minutes
+ // in a day.
+ static void SetMinimumMinutesBetweenVisits(unsigned int minutes);
+
+ // Bucket a given time to the given resolution in local time.
+ static base::Time BucketTimeToResolution(base::Time time,
+ unsigned int minutes);
+
+ // Queries a field trial for updates to the default number of minutes between
+ // site visits counted for the purposes of displaying a banner.
+ static void UpdateMinutesBetweenVisits();
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(AppBannerSettingsHelper);
};
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698