media/renderers/gpu_video_accelerator_factories.h - Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/gpu_video_accelerator_factories.h

Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address andresantoso's comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/blink/skcanvas_video_renderer.cc ('K') | « media/blink/skcanvas_video_renderer.cc ('k') | media/renderers/mock_gpu_video_accelerator_factories.h » ('j') | media/renderers/mock_gpu_video_accelerator_factories.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/renderers/gpu_video_accelerator_factories.h

diff --git a/media/renderers/gpu_video_accelerator_factories.h b/media/renderers/gpu_video_accelerator_factories.h

index c6f728e9b8d8ddabdd9d5cbb9e9c73de56a2931a..ef58ad4423f0cc25db60f0ce6228165d6046c05d 100644

--- a/media/renderers/gpu_video_accelerator_factories.h

+++ b/media/renderers/gpu_video_accelerator_factories.h

@@ -12,6 +12,7 @@

#include "gpu/command_buffer/client/gles2_interface.h"

#include "gpu/command_buffer/common/mailbox.h"

#include "media/base/media_export.h"

+#include "media/base/video_types.h"

#include "media/video/video_decode_accelerator.h"

#include "media/video/video_encode_accelerator.h"

#include "ui/gfx/gpu_memory_buffer.h"

@@ -70,6 +71,7 @@ class MEDIA_EXPORT GpuVideoAcceleratorFactories

virtual bool ShouldUseGpuMemoryBuffersForVideoFrames() const = 0;

virtual unsigned ImageTextureTarget() = 0;

+ virtual VideoPixelFormat VideoFramePixelFormat() = 0;

xhwang 2015/08/21 20:53:07 add a comment?

Daniele Castagna 2015/08/21 21:28:17 Done.

virtual bool IsTextureRGSupported() = 0;

virtual gpu::gles2::GLES2Interface* GetGLES2Interface() = 0;