Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: media/blink/skcanvas_video_renderer.cc

Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Address andresantoso's comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/skcanvas_video_renderer.cc
diff --git a/media/blink/skcanvas_video_renderer.cc b/media/blink/skcanvas_video_renderer.cc
index a36a9ede331471f45ece7148dbf27206262abec0..6aa863e89b1bc19cfc92a8ad2f84c89f2be6c209 100644
--- a/media/blink/skcanvas_video_renderer.cc
+++ b/media/blink/skcanvas_video_renderer.cc
@@ -138,7 +138,8 @@ bool ShouldCacheVideoFrameSkImage(const VideoFrame* video_frame) {
skia::RefPtr<SkImage> NewSkImageFromVideoFrameNative(
VideoFrame* video_frame,
const Context3D& context_3d) {
- DCHECK_EQ(PIXEL_FORMAT_ARGB, video_frame->format());
+ DCHECK(PIXEL_FORMAT_ARGB == video_frame->format() ||
+ PIXEL_FORMAT_UYVY == video_frame->format());
reveman 2015/08/21 21:53:03 and why this change?
Daniele Castagna 2015/08/21 22:46:04 Same as the above, if the VideoFrame gets converte
reveman 2015/08/22 14:04:46 what is this format used for? determines how to sa
const gpu::MailboxHolder& mailbox_holder = video_frame->mailbox_holder(0);
DCHECK(mailbox_holder.texture_target == GL_TEXTURE_2D ||

Powered by Google App Engine
This is Rietveld 408576698