media/base/video_frame.cc - Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_frame.cc

Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaned up. VideoFormat propagated. Test. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | media/renderers/gpu_video_accelerator_factories.h » ('j') | media/renderers/mock_gpu_video_accelerator_factories.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/video_frame.cc

diff --git a/media/base/video_frame.cc b/media/base/video_frame.cc

index 892cbe30b9fe8bc9193213b7c4a26749b1ad2cbd..9eccd0667b51de5c658f4a8edc4973d3445c2656 100644

--- a/media/base/video_frame.cc

+++ b/media/base/video_frame.cc

@@ -223,7 +223,7 @@ scoped_refptr<VideoFrame> VideoFrame::WrapNativeTexture(

const gfx::Rect& visible_rect,

const gfx::Size& natural_size,

base::TimeDelta timestamp) {

- if (format != PIXEL_FORMAT_ARGB) {

+ if (format != PIXEL_FORMAT_ARGB && format != PIXEL_FORMAT_UYVY) {

DLOG(ERROR) << "Only ARGB pixel format supported, got "

Andre 2015/08/21 18:18:36 Update error string, maybe "Unsupported pixel form

Daniele Castagna 2015/08/21 18:49:01 Done.

<< VideoPixelFormatToString(format);

return nullptr;