Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1306683003: Treat the x*1 generated by parsing a unary + as containing a dot. (Closed)

Created:
5 years, 3 months ago by bradn
Modified:
5 years, 3 months ago
Reviewers:
titzer, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Treat the x*1 generated by parsing a unary + as containing a dot. Since we convert +x to x*1, we loose information about whether the 1 was intended to be a floating point value for asm.js or not. Mark the generated 1 as containing a dot (i.e. 1.0). BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-parser R=rossberg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/4d3a0a7ce69c6ac3210018664368f0e29da6df0d Cr-Commit-Position: refs/heads/master@{#30481}

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bradn
5 years, 3 months ago (2015-08-30 06:38:14 UTC) #2
titzer
lgtm
5 years, 3 months ago (2015-08-31 08:20:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306683003/20001
5 years, 3 months ago (2015-08-31 16:12:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-08-31 16:35:56 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 16:36:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d3a0a7ce69c6ac3210018664368f0e29da6df0d
Cr-Commit-Position: refs/heads/master@{#30481}

Powered by Google App Engine
This is Rietveld 408576698