Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: components/variations/service/variations_service.h

Issue 1306653004: Expand FeatureList to support FieldTrial association. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/proto/study.proto ('k') | components/variations/service/variations_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/service/variations_service.h
diff --git a/components/variations/service/variations_service.h b/components/variations/service/variations_service.h
index def6124eed20fa139976b82dac3c103f56523809..32fd34b4bae9bb396e480ddf5136e87b04b631af 100644
--- a/components/variations/service/variations_service.h
+++ b/components/variations/service/variations_service.h
@@ -28,6 +28,7 @@ class PrefService;
class PrefRegistrySimple;
namespace base {
+class FeatureList;
class Version;
}
@@ -72,10 +73,12 @@ class VariationsService
~VariationsService() override;
- // Creates field trials based on Variations Seed loaded from local prefs. If
- // there is a problem loading the seed data, all trials specified by the seed
- // may not be created.
- bool CreateTrialsFromSeed();
+ // Creates field trials based on the variations seed loaded from local state.
+ // If there is a problem loading the seed data, all trials specified by the
+ // seed may not be created. Some field trials are configured to override or
+ // associate with (for reporting) specific features. These associations are
+ // registered with |feature_list|.
+ bool CreateTrialsFromSeed(base::FeatureList* feature_list);
// Should be called before startup of the main message loop.
void PerformPreMainMessageLoopStartup();
« no previous file with comments | « components/variations/proto/study.proto ('k') | components/variations/service/variations_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698