chrome/browser/chrome_browser_main.cc - Issue 1306653004: Expand FeatureList to support FieldTrial association.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 1306653004: Expand FeatureList to support FieldTrial association. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: overriden -> overridden; at() -> find() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index f23f18542f51ede9de4c8bd49ec8c346e414c4a1..9e40a1bfc48a5d3c0d4393dd4fdcc59d72499642 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -678,9 +678,8 @@ void ChromeBrowserMainParts::SetupMetricsAndFieldTrials() {

variations::VariationsService* variations_service =

browser_process_->variations_service();

if (variations_service)

- variations_service->CreateTrialsFromSeed();

+ variations_service->CreateTrialsFromSeed(feature_list.get());

- // TODO(asvitkine): Pass |feature_list| to CreateTrialsFromSeed() above.

base::FeatureList::SetInstance(feature_list.Pass());

// This must be called after |local_state_| is initialized.

« base/feature_list.h ('K') | « base/metrics/field_trial_unittest.cc ('k') | components/variations/proto/study.proto » ('j') | no next file with comments »