Issue 130663002: Get rid of fullPath in the metadata cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130663002: Get rid of fullPath in the metadata cache. (Closed)

Created:
6 years, 11 months ago by mtomasz

Modified:
6 years, 11 months ago

Reviewers:
hirono

CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of fullPath in the metadata cache. This patch removes the last instance of fullPath from the metadata cache, by using volume manager and its getLocationInformation method. TEST=Tested manually. BUG=320967 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243812

Patch Set 1 #

Patch Set 2 : Fixed. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
M	chrome/browser/resources/file_manager/foreground/js/file_manager.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/media/audio_player.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/media/video_player.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js	View	1	3 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/130663002/30001

6 years, 11 months ago (2014-01-09 03:49:15 UTC) #3

Message was sent while issue was closed.

Change committed as 243812

Expand Messages | Collapse Messages