Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 1306613002: Keep auxilliary media objects on the heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index d45ec851da3101088a86619cc758cd05dd8490b5..bf9e4a8dc6d92ce3216c09fdae196e7fbc9f1f21 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -103,7 +103,7 @@ public:
bool isPlayingRemotely() const { return m_playingRemotely; }
// error state
- PassRefPtrWillBeRawPtr<MediaError> error() const;
+ MediaError* error() const;
// network state
void setSrc(const AtomicString&);
@@ -117,7 +117,7 @@ public:
WebMediaPlayer::Preload preloadType() const;
WebMediaPlayer::Preload effectivePreloadType() const;
- PassRefPtrWillBeRawPtr<TimeRanges> buffered() const;
+ TimeRanges* buffered() const;
void load();
String canPlayType(const String& mimeType, const String& keySystem = String()) const;
@@ -136,8 +136,8 @@ public:
double playbackRate() const;
void setPlaybackRate(double);
void updatePlaybackRate();
- PassRefPtrWillBeRawPtr<TimeRanges> played();
- PassRefPtrWillBeRawPtr<TimeRanges> seekable() const;
+ TimeRanges* played();
+ TimeRanges* seekable() const;
bool ended() const;
bool autoplay() const;
bool loop() const;
@@ -364,7 +364,7 @@ private:
void clearMediaPlayerAndAudioSourceProviderClientWithoutLocking();
bool havePotentialSourceChild();
void noneSupported();
- void mediaEngineError(PassRefPtrWillBeRawPtr<MediaError>);
+ void mediaEngineError(MediaError*);
void cancelPendingEventsAndCallbacks();
void waitForSourceChange();
void prepareToPlay();
@@ -451,7 +451,7 @@ private:
Timer<HTMLMediaElement> m_progressEventTimer;
Timer<HTMLMediaElement> m_playbackProgressTimer;
Timer<HTMLMediaElement> m_audioTracksTimer;
- RefPtrWillBeMember<TimeRanges> m_playedTimeRanges;
+ PersistentWillBeMember<TimeRanges> m_playedTimeRanges;
OwnPtrWillBeMember<GenericEventQueue> m_asyncEventQueue;
double m_playbackRate;
@@ -461,7 +461,7 @@ private:
ReadyState m_readyStateMaximum;
KURL m_currentSrc;
- RefPtrWillBeMember<MediaError> m_error;
+ PersistentWillBeMember<MediaError> m_error;
double m_volume;
double m_lastSeekTime;
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698