Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306613002: Keep auxilliary media objects on the heap always. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, slimming-paint-reviews_chromium.org, nessy, vivekg, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vivekg_samsung, Inactive, blink-reviews-paint_chromium.org, dshwang, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Keep auxilliary media objects on the heap always. Fully transition MediaError, MediaKeyError and TimeRanges to Oilpan. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -105 lines) Patch
M Source/core/html/HTMLMediaElement.h View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLMediaSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaController.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/MediaError.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/html/MediaError.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaKeyError.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/html/MediaKeyError.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaKeyEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeRanges.h View 3 chunks +8 lines, -9 lines 0 comments Download
M Source/core/html/TimeRanges.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/TimeRanges.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeRangesTest.cpp View 19 chunks +33 lines, -33 lines 0 comments Download
M Source/core/paint/MediaControlsPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 4 months ago (2015-08-20 21:22:25 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-21 00:21:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306613002/1
5 years, 4 months ago (2015-08-21 05:15:35 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 05:20:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200962

Powered by Google App Engine
This is Rietveld 408576698