Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: mojo/devtools/common/android_stack_parser/stack_utils_unittest.py

Issue 1306603002: Improve android stack parser (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/devtools/common/android_stack_parser/stack_utils_unittest.py
diff --git a/mojo/devtools/common/android_stack_parser/stack_utils_unittest.py b/mojo/devtools/common/android_stack_parser/stack_utils_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..913f6728cc64a709c51db141fa9fd426c6fcaee0
--- /dev/null
+++ b/mojo/devtools/common/android_stack_parser/stack_utils_unittest.py
@@ -0,0 +1,75 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Tests for the native crash dump symbolizer utility functions."""
+
+import unittest
+import stack_utils
+
+
+class StackUtilsTest(unittest.TestCase):
+ """Tests the native crash dump symbolizer utility functions.
ppi 2015/08/21 14:53:07 nit: the closing """ on the first line if the enti
etiennej 2015/08/21 15:07:18 Done.
+ """
+
+ def test_GetSymbolMapping_no_match(self):
+ """Verifies that, if no mapping is on the input, no mapping is on the
+ output.
+ """
+ lines = ["This is a test case\n", "Caching all mojo apps", ""]
+ self.assertDictEqual({}, stack_utils.GetSymbolMapping(lines))
+
+ def test_GetSymbolMapping_simple_match(self):
+ """Verifies a simple symbol mapping.
+ """
ppi 2015/08/21 14:53:07 ditto, and same in the others below
etiennej 2015/08/21 15:07:18 Done.
+ lines = ["This is a test case\n", "Caching all mojo apps",
+ "I/mojo(2): [INFO:somefile.cc(85)] Caching mojo app "
+ "https://apps.mojo/myapp.mojo at /path/to/myapp.mojo/.lM03ws"]
+ golden_dict = {
+ "/path/to/myapp.mojo/.lM03ws": "libmyapp_library.so"
+ }
+ actual_dict = stack_utils.GetSymbolMapping(lines)
+ self.assertDictEqual(golden_dict, actual_dict)
+
+ def test_GetSymbolMapping_multiple_match(self):
+ """Verifies mapping of multiple symbol files.
+ """
+ lines = ["This is a test case\n", "Caching all mojo apps",
+ "I/mojo(2): [INFO:somefile.cc(85)] Caching mojo app "
+ "https://apps.mojo/myapp.mojo at /path/to/myapp.mojo/.lM03ws",
+ "I/mojo(2): [INFO:somefile.cc(85)] Caching mojo app "
+ "https://apps.mojo/otherapp.mojo at /path/to/otherapp.mojo/.kW07s"]
+ golden_dict = {
+ "/path/to/myapp.mojo/.lM03ws": "libmyapp_library.so",
+ "/path/to/otherapp.mojo/.kW07s": "libotherapp_library.so"
+ }
+ actual_dict = stack_utils.GetSymbolMapping(lines)
+ self.assertDictEqual(golden_dict, actual_dict)
+
+ def test_GetSymbolMapping_parameter_match(self):
+ """Verifies parameters are stripped from mappings.
+ """
+ lines = ["This is a test case\n", "Caching all mojo apps",
+ "I/mojo(2): [INFO:somefile.cc(85)] Caching mojo app "
+ "https://apps.mojo/myapp.mojo?q=hello at /path/to/myapp.mojo/.lM03ws"]
+ golden_dict = {
+ "/path/to/myapp.mojo/.lM03ws": "libmyapp_library.so"
+ }
+ actual_dict = stack_utils.GetSymbolMapping(lines)
+ self.assertDictEqual(golden_dict, actual_dict)
+
+ def test_GetSymbolMapping_normalize(self):
+ """Verifies paths are normalized in mappings.
+ """
+ lines = ["This is a test case\n", "Caching all mojo apps",
+ "I/mojo(2): [INFO:somefile.cc(85)] Caching mojo app "
+ "https://apps.mojo/myapp.mojo at /path/to/.//myapp.mojo/.lM03ws"]
+ golden_dict = {
+ "/path/to/myapp.mojo/.lM03ws": "libmyapp_library.so"
+ }
+ actual_dict = stack_utils.GetSymbolMapping(lines)
+ self.assertDictEqual(golden_dict, actual_dict)
+
+
+if __name__ == "__main__":
+ unittest.main()

Powered by Google App Engine
This is Rietveld 408576698