Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: mojo/devtools/common/android_stack_parser/stack

Issue 1306603002: Improve android stack parser (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/android_stack_parser/stack
diff --git a/mojo/devtools/common/android_stack_parser/stack b/mojo/devtools/common/android_stack_parser/stack
index 97913ab84191ed7e8d87219a50b702b28762815b..549bfb56afa1412671906ad5e0f06655e65c31e9 100755
--- a/mojo/devtools/common/android_stack_parser/stack
+++ b/mojo/devtools/common/android_stack_parser/stack
@@ -19,6 +19,7 @@
import getopt
import glob
import os
+import os.path
import re
import sys
@@ -133,13 +134,14 @@ def GetSymboledNameForMojoApp(path):
def GetSymbolMapping(lines):
"""Returns a mapping (dictionary) from download file to .so."""
ppi 2015/08/21 08:15:11 Would it be feasible to add a unittest for this pa
etiennej 2015/08/21 14:43:06 Done.
- regex = re.compile('Caching mojo app (\S+) at (\S+)')
+ regex = re.compile('Caching mojo app (\S+?)(?:\?\S+)? at (\S+)')
mappings = {}
for line in lines:
result = regex.search(line)
if result:
url = GetBasenameFromMojoApp(result.group(1))
- mappings[result.group(2)] = GetSymboledNameForMojoApp(url)
+ mappings[os.path.normpath(result.group(2))] = GetSymboledNameForMojoApp(
+ url)
return mappings
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698