Improve android stack parser

Improve android stack parser

There was several issues with the Android stack parser that prevented it
to work correctly in a number of cases. The two cases fixed here:
 - When a mojo app is retrieved with arguments
(dart_content_handler.mojo?strict=true), we want to ignore ?strict=true
when looking for a match on the local filesystem.
 - There were cases when paths were not normalized correctly (for example,
double-slashes), preventing the libraries to match.

This fixes domokit/devtools#23

R=ppi@chromium.org, ppi

Committed: https://chromium.googlesource.com/external/mojo/+/763f44f16c1f564be73b9c6dbaef3edba542b157

[etiennej, 2015-08-20 14:58:49]

Patchset #1 (id:1) has been deleted

[ppi, 2015-08-21 08:15:11]

nice

https://codereview.chromium.org/1306603002/diff/20001/mojo/devtools/common/an...
File mojo/devtools/common/android_stack_parser/stack (right):

https://codereview.chromium.org/1306603002/diff/20001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack:17: """stack symbolizes native
crash dumps."""
Does this patch fix https://github.com/domokit/devtools/issues/23 ?

If so, please add "fixes domokit/devtools#23" in the description.

https://codereview.chromium.org/1306603002/diff/20001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack:136: """Returns a mapping
(dictionary) from download file to .so."""
Would it be feasible to add a unittest for this particular function illustrating
the fix?

[etiennej, 2015-08-21 14:43:07]

https://codereview.chromium.org/1306603002/diff/20001/mojo/devtools/common/an...
File mojo/devtools/common/android_stack_parser/stack (right):

https://codereview.chromium.org/1306603002/diff/20001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack:17: """stack symbolizes native
crash dumps."""
On 2015/08/21 08:15:11, ppi wrote:
> Does this patch fix https://github.com/domokit/devtools/issues/23 ?
> 
> If so, please add "fixes domokit/devtools#23" in the description.

Done.

https://codereview.chromium.org/1306603002/diff/20001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack:136: """Returns a mapping
(dictionary) from download file to .so."""
On 2015/08/21 08:15:11, ppi wrote:
> Would it be feasible to add a unittest for this particular function
illustrating
> the fix?

Done.

[ppi, 2015-08-21 14:53:07]

fantastic % nits

PS lgtm in case Rietveld doesn't pick up "fantastic" as an alias for it.

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
File mojo/devtools/common/android_stack_parser/stack_utils.py (right):

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack_utils.py:11: 
two blank lines please

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
File mojo/devtools/common/android_stack_parser/stack_utils_unittest.py (right):

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack_utils_unittest.py:12: """Tests
the native crash dump symbolizer utility functions.
nit: the closing """ on the first line if the entire pydoc fits in one line.

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack_utils_unittest.py:24: """
ditto, and same in the others below

https://codereview.chromium.org/1306603002/diff/40001/mojo/tools/run_mojo_pyt...
File mojo/tools/run_mojo_python_tests.py (right):

https://codereview.chromium.org/1306603002/diff/40001/mojo/tools/run_mojo_pyt...
mojo/tools/run_mojo_python_tests.py:20: # Tests of the android stack parser (in
devtools).
nit: no need to state the obvious, I'd drop this comment (and just list the two
devtools paths one after another).

[etiennej, 2015-08-21 15:07:18]

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
File mojo/devtools/common/android_stack_parser/stack_utils.py (right):

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack_utils.py:11: 
On 2015/08/21 14:53:07, ppi wrote:
> two blank lines please

Done.

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
File mojo/devtools/common/android_stack_parser/stack_utils_unittest.py (right):

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack_utils_unittest.py:12: """Tests
the native crash dump symbolizer utility functions.
On 2015/08/21 14:53:07, ppi wrote:
> nit: the closing """ on the first line if the entire pydoc fits in one line.

Done.

https://codereview.chromium.org/1306603002/diff/40001/mojo/devtools/common/an...
mojo/devtools/common/android_stack_parser/stack_utils_unittest.py:24: """
On 2015/08/21 14:53:07, ppi wrote:
> ditto, and same in the others below

Done.

https://codereview.chromium.org/1306603002/diff/40001/mojo/tools/run_mojo_pyt...
File mojo/tools/run_mojo_python_tests.py (right):

https://codereview.chromium.org/1306603002/diff/40001/mojo/tools/run_mojo_pyt...
mojo/tools/run_mojo_python_tests.py:20: # Tests of the android stack parser (in
devtools).
On 2015/08/21 14:53:07, ppi wrote:
> nit: no need to state the obvious, I'd drop this comment (and just list the
two
> devtools paths one after another).

Done.

[etiennej, 2015-08-21 15:07:43]

Committed patchset #3 (id:60001) manually as
763f44f16c1f564be73b9c6dbaef3edba542b157 (presubmit successful).