Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Issue 1306553002: Implement extended master secret in tlslite (again) (Closed)

Created:
5 years, 4 months ago by nharper
Modified:
5 years, 4 months ago
Reviewers:
jbudorick, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement extended master secret in tlslite (again) Originally implemented in https://codereview.chromium.org/1283373002/, was reverted in https://codereview.chromium.org/1299153002/. This cl includes a fix for the test that failed (SSLClientSocketOpenSSLClientAuthTest.SendGoodCert). BUG=467312 Committed: https://crrev.com/be964395f338c3419cec900c43f61034040db825 Cr-Commit-Position: refs/heads/master@{#344520}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -14 lines) Patch
M third_party/tlslite/README.chromium View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/tlslite/patches/extended_master_secret.patch View 1 chunk +222 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/mathtls.py View 1 chunk +11 lines, -7 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 4 chunks +7 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 7 chunks +17 lines, -6 lines 0 comments Download
M third_party/tlslite/tlslite/tlsrecordlayer.py View 4 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
nharper
5 years, 4 months ago (2015-08-20 02:51:26 UTC) #2
davidben
lgtm https://codereview.chromium.org/1306553002/diff/1/third_party/tlslite/tlslite/tlsrecordlayer.py File third_party/tlslite/tlslite/tlsrecordlayer.py (right): https://codereview.chromium.org/1306553002/diff/1/third_party/tlslite/tlslite/tlsrecordlayer.py#newcode819 third_party/tlslite/tlslite/tlsrecordlayer.py:819: self._ems_handshake_hash = self._getHandshakeHash() Oh. That was the problem. ...
5 years, 4 months ago (2015-08-20 15:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306553002/1
5 years, 4 months ago (2015-08-20 16:46:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 16:52:14 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 16:52:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be964395f338c3419cec900c43f61034040db825
Cr-Commit-Position: refs/heads/master@{#344520}

Powered by Google App Engine
This is Rietveld 408576698