Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1814)

Unified Diff: chrome/browser/chromeos/drive/drive_url_request_job.h

Issue 13065007: Fix data overwriting issue on ReadFromDownloadData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/drive_url_request_job.h
diff --git a/chrome/browser/chromeos/drive/drive_url_request_job.h b/chrome/browser/chromeos/drive/drive_url_request_job.h
index 7862e77953495b54cef4de72b0ee43475437c28d..ff71fae0ba76a9b81298fd1c6e535abfdda5f5dd 100644
--- a/chrome/browser/chromeos/drive/drive_url_request_job.h
+++ b/chrome/browser/chromeos/drive/drive_url_request_job.h
@@ -11,6 +11,7 @@
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
#include "base/memory/weak_ptr.h"
#include "base/string_piece.h"
#include "chrome/browser/chromeos/drive/drive_file_error.h"
@@ -131,8 +132,7 @@ class DriveURLRequestJob : public net::URLRequestJob {
bool streaming_download_;
scoped_refptr<net::IOBuffer> read_buf_;
base::StringPiece read_buf_remaining_;
- std::string download_buf_;
- base::StringPiece download_buf_remaining_;
+ ScopedVector<std::string> pending_downloaded_data_;
// This should remain the last member so it'll be destroyed first and
// invalidate its weak pointers before other members are destroyed.

Powered by Google App Engine
This is Rietveld 408576698