Fix data overwriting issue on ReadFromDownloadData.

chrome/browser/chromeos/drive/drive_url_request_job.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_DRIVE_DRIVE_URL_REQUEST_JOB_H_
 #define CHROME_BROWSER_CHROMEOS_DRIVE_DRIVE_URL_REQUEST_JOB_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string_piece.h"
 #include "chrome/browser/chromeos/drive/drive_file_error.h"
 #include "chrome/browser/chromeos/drive/drive_resource_metadata.h"
 #include "chrome/browser/google_apis/gdata_errorcode.h"
 #include "net/url_request/url_request_job.h"
 
 namespace net {
 class FileStream;
 class HttpResponseInfo;
 class IOBuffer;
 class NetworkDelegate;
 class URLRequest;
 }  // namespace net
 
 namespace drive {
 
 class DriveEntryProto;
 class DriveFileSystemInterface;
 
 // DriveURLRequesetJob is the gateway between network-level drive://...
 // requests for drive resources and DriveFileSytem.  It exposes content URLs
 // formatted as drive://<resource-id>.
 // The methods should be run on IO thread.
+// This class seems to have some timing issue and to handle edge cases somehow
+// wrongly. Also, probably because of the requirement change, the code path
+// is getting complicated.
+// TODO(hidehiko): Clean the code up and handles edge cases correctly.
 class DriveURLRequestJob : public net::URLRequestJob {
  public:
 
   // Callback to return the DriveFileSystemInterface instance. This is an
   // injecting point for testing.
   // Note that the callback will be copied between threads (IO and UI), and
   // will be called on UI thread.
   typedef base::Callback<DriveFileSystemInterface*()> DriveFileSystemGetter;
 
   DriveURLRequestJob(
@@ skipping 76 matching lines @@
   base::FilePath local_file_path_;
   base::FilePath drive_file_path_;
   std::string mime_type_;
   int64 initial_file_size_;
   int64 remaining_bytes_;
   scoped_ptr<net::FileStream> stream_;
   scoped_ptr<net::HttpResponseInfo> response_info_;
   bool streaming_download_;
   scoped_refptr<net::IOBuffer> read_buf_;
   base::StringPiece read_buf_remaining_;
-  std::string download_buf_;
-  base::StringPiece download_buf_remaining_;
+  ScopedVector<std::string> pending_downloaded_data_;
 
   // This should remain the last member so it'll be destroyed first and
   // invalidate its weak pointers before other members are destroyed.
   base::WeakPtrFactory<DriveURLRequestJob> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(DriveURLRequestJob);
 };
 
 }  // namespace drive
 
 #endif  // CHROME_BROWSER_CHROMEOS_DRIVE_DRIVE_URL_REQUEST_JOB_H_