Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306473003: make use of use_glib variable rather than is_linux when adding glib config (Closed)

Created:
5 years, 4 months ago by Mostyn Bramley-Moore
Modified:
5 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make use of use_glib variable rather than is_linux when adding glib config Committed: https://crrev.com/6c63a157f06de29c2c4cc1ea4b17ce16a6f22493 Cr-Commit-Position: refs/heads/master@{#344877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/base/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306473003/1
5 years, 4 months ago (2015-08-20 13:11:02 UTC) #2
Mostyn Bramley-Moore
@sadrul: please take a look at this small modification.
5 years, 4 months ago (2015-08-20 13:11:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-20 13:43:59 UTC) #6
sadrul
lgtm
5 years, 4 months ago (2015-08-21 19:30:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306473003/1
5 years, 4 months ago (2015-08-21 21:33:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 22:18:02 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 22:18:32 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6c63a157f06de29c2c4cc1ea4b17ce16a6f22493
Cr-Commit-Position: refs/heads/master@{#344877}

Powered by Google App Engine
This is Rietveld 408576698