Chromium Code Reviews| Index: content/browser/device_sensors/sensor_manager_chromeos.cc |
| diff --git a/content/browser/device_sensors/sensor_manager_chromeos.cc b/content/browser/device_sensors/sensor_manager_chromeos.cc |
| index 36bdadd81fea719fc52bd3b76484a1709ef4ca8a..48d63a6175fa207a948aa38f0a63cd1d1b77aa21 100644 |
| --- a/content/browser/device_sensors/sensor_manager_chromeos.cc |
| +++ b/content/browser/device_sensors/sensor_manager_chromeos.cc |
| @@ -140,11 +140,7 @@ void SensorManagerChromeOS::GenerateOrientationEvent(double x, |
| return; |
| // Create a unit vector for trigonometry |
| - // TODO(jonross): Stop reversing signs for vector components once |
| - // accelerometer values have been fixed. crbug.com/431391 |
|
timvolodine
2015/08/27 15:16:59
q: has crbug.com/431391 been fixed?
jonross
2015/08/27 15:21:57
There have been changes on the firmware/kernel sid
|
| - // Ternaries are to remove -0.0f which gives incorrect trigonometrical |
| - // results. |
| - gfx::Vector3dF data(x, y ? -y : 0.0f, z ? -z : 0.0f); |
| + gfx::Vector3dF data(x, y, z); |
| data.Scale(1.0f / data.Length()); |
| // Transform accelerometer to W3C angles, using the Z-X-Y Eulerangles matrix. |