Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306443004: Use static_assert instead of SK_COMPILE_ASSERT. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use static_assert instead of SK_COMPILE_ASSERT. Now that static_assert is allowed, there is no need to use a non- standard compile time assertion Committed: https://skia.googlesource.com/skia/+/99fe82260633fcf5d92cca38d12ef0937ecca61c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -209 lines) Patch
M bench/DashBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convex_all_line_paths.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pixelsnap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/variedtext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkImageInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkPath.h View 2 chunks +8 lines, -8 lines 0 comments Download
M include/core/SkTypes.h View 2 chunks +1 line, -15 lines 0 comments Download
M include/gpu/GrTypes.h View 1 chunk +4 lines, -4 lines 0 comments Download
M include/private/SkRecords.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/core/SkClipStack.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M src/core/SkConvolver.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkResourceCache.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkStroke.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkTextBlob.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkTextFormatParams.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/core/SkVarAlloc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrBatchFontCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPath.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrStrokeInfo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkScaledBitmapSampler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +9 lines, -16 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_android_parser.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkOSFile_posix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkOSFile_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkIBMFamilyClass.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTableTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2_V0.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTable_OS_2_V1.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTable_OS_2_V2.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTable_OS_2_V3.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTable_OS_2_V4.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTable_OS_2_VA.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTTable_gasp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_head.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_hhea.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_maxp_CFF.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_maxp_TT.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkOTTable_name.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/sfnt/SkOTTable_post.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkPanose.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkSFNTHeader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sfnt/SkTTCFHeader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/svg/SkSVGDevice.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkTFitsIn.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/views/mac/SkNSView.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/views/mac/SkOSWindow_Mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306443004/1
5 years, 4 months ago (2015-08-19 21:55:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 22:02:18 UTC) #4
bungeman-skia
Note that this should not land until Android is ready for it (in progress).
5 years, 4 months ago (2015-08-19 22:03:16 UTC) #6
mtklein
lgtm I would have done the same mechanical translation.
5 years, 4 months ago (2015-08-19 22:11:42 UTC) #7
reed1
lgtm
5 years, 4 months ago (2015-08-20 14:07:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306443004/1
5 years, 4 months ago (2015-08-20 14:56:58 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 14:57:55 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/99fe82260633fcf5d92cca38d12ef0937ecca61c

Powered by Google App Engine
This is Rietveld 408576698