Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1306443002: Disable regress-crbug-518748. It is failing/flaking on many bots (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable regress-crbug-518748. It is failing/flaking on many bots BUG=chromium:518748 TBR=mstarzinger@chromium.org LOG=n Committed: https://chromium.googlesource.com/v8/v8/+/8f441181a570c44ef5c949e8dfd9fd326ac10345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
Committed patchset #1 (id:1) manually as 8f441181a570c44ef5c949e8dfd9fd326ac10345 (presubmit successful).
5 years, 4 months ago (2015-08-19 17:48:57 UTC) #1
Michael Starzinger
Is there a plan to make the test more solid in the future? Because if ...
5 years, 4 months ago (2015-08-19 18:25:01 UTC) #2
Michael Starzinger
LGTM for de-flaking of course. :)
5 years, 4 months ago (2015-08-19 18:26:19 UTC) #3
binji
On 2015/08/19 at 18:25:01, mstarzinger wrote: > Is there a plan to make the test ...
5 years, 4 months ago (2015-08-19 18:52:18 UTC) #4
Michael Starzinger
5 years, 4 months ago (2015-08-19 18:52:55 UTC) #5
Message was sent while issue was closed.
On 2015/08/19 18:52:18, binji wrote:
> On 2015/08/19 at 18:25:01, mstarzinger wrote:
> > Is there a plan to make the test more solid in the future? Because if not,
> then I would just vote for removing/deleting the regression test. Having it
> disabled for an indefinite amount of time doesn't buy us much. I would be fine
> with removing/deleting it if investing more time doesn't make sense in this
> case. Up to you.
> 
> Yeah, I can't really think of a way to make this more robust. It doesn't seem
> possible to know whether creating a new thread will have enough memory ahead
of
> time, so all I can do is play with the worker limit.

Nah, let's just remove the test then.

Powered by Google App Engine
This is Rietveld 408576698