[NetInfo] Browser changes to support connection.downlinkMax

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 476 matching lines @@
 
   // Certain GPU features might have been blacklisted.
   GpuDataManagerImpl::GetInstance()->UpdateRendererWebPrefs(&prefs);
 
   if (ChildProcessSecurityPolicyImpl::GetInstance()->HasWebUIBindings(
           GetProcess()->GetID())) {
     prefs.loads_images_automatically = true;
     prefs.javascript_enabled = true;
   }
 
-  prefs.connection_type = net::NetworkChangeNotifier::GetConnectionType();
-  prefs.is_online =
-      prefs.connection_type != net::NetworkChangeNotifier::CONNECTION_NONE;
+  prefs.net_info_connection_type =
+      net::NetworkChangeNotifier::GetConnectionType();
+  prefs.net_info_max_bandwidth_mbps =
+      net::NetworkChangeNotifier::GetMaxBandwidth();

[pauljensen, 2015/09/11 14:25:37]

This looks racy.  Connection type could have changed before the GetMaxBandwidth
call.

[jkarlin, 2015/09/11 20:15:21]

Ugh, I forgot NCN was thread safe. Okay, changed GetMaxBandwidth to supply both
values in the upstream CL and used it here.

+  prefs.is_online = prefs.net_info_connection_type !=
+                    net::NetworkChangeNotifier::CONNECTION_NONE;
 
   prefs.number_of_cpu_cores = base::SysInfo::NumberOfProcessors();
 
   prefs.viewport_enabled =
       command_line.HasSwitch(switches::kEnableViewport) ||
       prefs.viewport_meta_enabled;
 
   prefs.main_frame_resizes_are_orientation_changes =
       command_line.HasSwitch(switches::kMainFrameResizesAreOrientationChanges);
 
@@ skipping 920 matching lines @@
     if (!policy->CanReadFile(GetProcess()->GetID(), file))
       policy->GrantReadFile(GetProcess()->GetID(), file);
   }
 }
 
 void RenderViewHostImpl::SelectWordAroundCaret() {
   Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
 }
 
 }  // namespace content