[builtins] Pass correct number of arguments after adapting arguments.

[builtins] Pass correct number of arguments after adapting arguments.

The call protocol requires that the register dedicated to the number of
actual arguments (i.e. rax on x64) always contains the actual arguments.
That means after adapting arguments it should match the number of
expected arguments.  But currently we pass some semi-random value
(usually some stack address) after adapting arguments.

It looks like this is currently not observable anywhere, because our
builtins and functions either don't look at the number of arguments and
just make hard coded (unchecked) assumptions, or are marked as "don't
adapt arguments", which bypasses the broken code in the trampoline for
arguments adaption.  Nevertheless this should be fixed.

R=mstarzinger@chromium.org

Committed: https://crrev.com/fbad63669e309e8c5c3f2ecf503df2fefaac79bb
Cr-Commit-Position: refs/heads/master@{#30467}

[Benedikt Meurer, 2015-08-31 10:37:46]

Hey Michi,

The bug we just discovered; it's not even an off-by-N...
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2015-08-31 10:57:09]

Patchset #1 (id:1) has been deleted

[Michael Starzinger, 2015-08-31 10:58:28]

LGTM.

[Benedikt Meurer, 2015-08-31 10:58:32]

bmeurer@chromium.org changed reviewers:
+ akos.palfi@imgtec.com, plind44@gmail.com, v8-mips-ports@googlegroups.com

[Benedikt Meurer, 2015-08-31 10:58:32]

Hey MIPS people,

Please port this fix to MIPS/MIPS64.

Thanks,
Benedikt

[Benedikt Meurer, 2015-08-31 11:27:25]

On 2015/08/31 10:58:32, Benedikt Meurer wrote:
> Hey MIPS people,
> 
> Please port this fix to MIPS/MIPS64.
> 
> Thanks,
> Benedikt

I forgot to mention: You can land that separately, as I wasn't able to construct
a regression test with current ToT.

[Benedikt Meurer, 2015-08-31 11:27:30]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-08-31 11:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306423003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306423003/20001

[commit-bot: I haz the power, 2015-08-31 11:28:57]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-08-31 11:29:09]

Patchset 1 (id:??) landed as
https://crrev.com/fbad63669e309e8c5c3f2ecf503df2fefaac79bb
Cr-Commit-Position: refs/heads/master@{#30467}