Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306413003: Make classes and structures in core/html fast-allocated. (Closed)

Created:
5 years, 4 months ago by tasak
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, Yoav Weiss, philipj_slow, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, Rik, Justin Novosad, nessy, dshwang, scheduler-bugs_chromium.org, vcarbune.chromium, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/html fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201204

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -2 lines) Patch
M Source/core/html/HTMLContentElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLDimension.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLImageFallbackHelper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/LinkRelAttribute.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/MediaFragmentURIParser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/TimeRanges.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContextFactory.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/forms/DateTimeChooser.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/forms/DateTimeFieldsState.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/forms/FormController.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/forms/StepRange.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/forms/TypeAhead.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImport.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportState.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/AtomicHTMLToken.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLInputStream.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/CompactHTMLToken.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLEntityParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLEntitySearch.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLEntityTable.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLInputStream.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLParserOptions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLParserThread.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLSourceTracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLSrcsetParser.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLToken.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLTokenizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/InputStreamPreprocessor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/PreloadRequest.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/TextResourceDecoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElements.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeNumericFieldElement.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/track/AutomaticTrackSelection.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/track/CueTimeline.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/BufferedLineReader.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTScanner.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTToken.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTTokenizer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tasak
Would you review this CL?
5 years, 4 months ago (2015-08-25 09:43:38 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-25 10:47:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306413003/20001
5 years, 4 months ago (2015-08-26 03:55:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/126154)
5 years, 4 months ago (2015-08-26 04:51:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306413003/20001
5 years, 4 months ago (2015-08-26 06:04:46 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 06:35:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201204

Powered by Google App Engine
This is Rietveld 408576698