Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 130633002: Linux: fix getting termination status for known dead processes. (Closed)

Created:
6 years, 11 months ago by jln (very slow on Chromium)
Modified:
6 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Linux: fix getting termination status for known dead processes. While a process is being destroyed by the kernel, it will loose its IPC file descriptors which signals to the browser that the process is dead. In that timeframe, doing a non blocking waitpid() is racy and can indicate the process as still being running while the kernel is still destroying it. We unify Linux with OS X and use known_dead even in the non Zygote case. BUG=332635 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/child_process_launcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Antoine, this is what I had in mind until we address crbug.com/332522 I did manually ...
6 years, 11 months ago (2014-01-09 03:37:21 UTC) #1
piman
LGTM. That's essentially what I came up with too. Having this in trunk should help ...
6 years, 11 months ago (2014-01-09 03:40:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/130633002/1
6 years, 11 months ago (2014-01-09 23:22:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111374
6 years, 11 months ago (2014-01-10 01:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/130633002/1
6 years, 11 months ago (2014-01-10 01:24:32 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 03:26:32 UTC) #6
Message was sent while issue was closed.
Change committed as 244069

Powered by Google App Engine
This is Rietveld 408576698