Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1306303006: Only build linux installer for desktop. (Closed)

Created:
5 years, 3 months ago by Peter Mayo
Modified:
5 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remoting
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only build linux installer for desktop. Embedded systems have other installer methods, like ChromeOS. BUG=517496 Committed: https://crrev.com/236fc0b795dc5a4722c187c891174984f28f3a77 Cr-Commit-Position: refs/heads/master@{#347543}

Patch Set 1 #

Patch Set 2 : reference rebase #

Patch Set 3 : rebase #

Patch Set 4 : sync&rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/installer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (4 generated)
Peter Mayo
5 years, 3 months ago (2015-09-04 01:57:46 UTC) #2
Peter Mayo
reference rebase
5 years, 3 months ago (2015-09-04 02:04:26 UTC) #3
Peter Mayo
+grt for OWNERS
5 years, 3 months ago (2015-09-04 02:09:11 UTC) #5
grt (UTC plus 2)
Rubberstamp owners lgtm. Please ask a linux person to review this for correctness.
5 years, 3 months ago (2015-09-04 13:56:19 UTC) #6
Dirk Pranke
lgtm.
5 years, 3 months ago (2015-09-04 15:49:20 UTC) #7
Peter Mayo
rebase
5 years, 3 months ago (2015-09-04 19:25:44 UTC) #8
Peter Mayo
sync&rebase
5 years, 3 months ago (2015-09-04 19:40:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306303006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306303006/60001
5 years, 3 months ago (2015-09-04 23:55:00 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-05 00:16:23 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 00:17:38 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/236fc0b795dc5a4722c187c891174984f28f3a77
Cr-Commit-Position: refs/heads/master@{#347543}

Powered by Google App Engine
This is Rietveld 408576698