Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/mips64/lithium-codegen-mips64.cc

Issue 1306303005: Revert of [es5] Class of object is "Function" if object has [[Call]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/mips64/macro-assembler-mips64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/code-stubs.h" 6 #include "src/code-stubs.h"
7 #include "src/cpu-profiler.h" 7 #include "src/cpu-profiler.h"
8 #include "src/hydrogen-osr.h" 8 #include "src/hydrogen-osr.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 2630 matching lines...) Expand 10 before | Expand all | Expand 10 after
2641 Handle<String>class_name, 2641 Handle<String>class_name,
2642 Register input, 2642 Register input,
2643 Register temp, 2643 Register temp,
2644 Register temp2) { 2644 Register temp2) {
2645 DCHECK(!input.is(temp)); 2645 DCHECK(!input.is(temp));
2646 DCHECK(!input.is(temp2)); 2646 DCHECK(!input.is(temp2));
2647 DCHECK(!temp.is(temp2)); 2647 DCHECK(!temp.is(temp2));
2648 2648
2649 __ JumpIfSmi(input, is_false); 2649 __ JumpIfSmi(input, is_false);
2650 2650
2651 STATIC_ASSERT(LAST_JS_RECEIVER_TYPE == LAST_TYPE); 2651 if (String::Equals(isolate()->factory()->Function_string(), class_name)) {
2652 __ GetObjectType(input, temp, temp2); 2652 // Assuming the following assertions, we can use the same compares to test
2653 __ Branch(is_false, lt, temp2, Operand(FIRST_JS_RECEIVER_TYPE)); 2653 // for both being a function type and being in the object type range.
2654 STATIC_ASSERT(NUM_OF_CALLABLE_SPEC_OBJECT_TYPES == 2);
2655 STATIC_ASSERT(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE ==
2656 FIRST_SPEC_OBJECT_TYPE + 1);
2657 STATIC_ASSERT(LAST_NONCALLABLE_SPEC_OBJECT_TYPE ==
2658 LAST_SPEC_OBJECT_TYPE - 1);
2659 STATIC_ASSERT(LAST_SPEC_OBJECT_TYPE == LAST_TYPE);
2654 2660
2655 // Objects with [[Call]] have class 'Function'. 2661 __ GetObjectType(input, temp, temp2);
2656 __ lbu(temp2, FieldMemOperand(temp, Map::kBitFieldOffset)); 2662 __ Branch(is_false, lt, temp2, Operand(FIRST_SPEC_OBJECT_TYPE));
2657 __ And(temp2, temp2, Operand(1 << Map::kIsCallable)); 2663 __ Branch(is_true, eq, temp2, Operand(FIRST_SPEC_OBJECT_TYPE));
2658 if (String::Equals(isolate()->factory()->Function_string(), class_name)) { 2664 __ Branch(is_true, eq, temp2, Operand(LAST_SPEC_OBJECT_TYPE));
2659 __ Branch(is_true, ne, temp2, Operand(zero_reg));
2660 } else { 2665 } else {
2661 __ Branch(is_false, ne, temp2, Operand(zero_reg)); 2666 // Faster code path to avoid two compares: subtract lower bound from the
2667 // actual type and do a signed compare with the width of the type range.
2668 __ GetObjectType(input, temp, temp2);
2669 __ Dsubu(temp2, temp2, Operand(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));
2670 __ Branch(is_false, gt, temp2, Operand(LAST_NONCALLABLE_SPEC_OBJECT_TYPE -
2671 FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));
2662 } 2672 }
2663 2673
2664 // Now we are in the FIRST-LAST_JS_RECEIVER_TYPE range. 2674 // Now we are in the FIRST-LAST_NONCALLABLE_SPEC_OBJECT_TYPE range.
2665 // Check if the constructor in the map is a function. 2675 // Check if the constructor in the map is a function.
2666 Register instance_type = scratch1(); 2676 Register instance_type = scratch1();
2667 DCHECK(!instance_type.is(temp)); 2677 DCHECK(!instance_type.is(temp));
2668 __ GetMapConstructor(temp, temp, temp2, instance_type); 2678 __ GetMapConstructor(temp, temp, temp2, instance_type);
2669 2679
2670 // Objects with a non-function constructor have class 'Object'. 2680 // Objects with a non-function constructor have class 'Object'.
2671 if (String::Equals(class_name, isolate()->factory()->Object_string())) { 2681 if (String::Equals(class_name, isolate()->factory()->Object_string())) {
2672 __ Branch(is_true, ne, instance_type, Operand(JS_FUNCTION_TYPE)); 2682 __ Branch(is_true, ne, instance_type, Operand(JS_FUNCTION_TYPE));
2673 } else { 2683 } else {
2674 __ Branch(is_false, ne, instance_type, Operand(JS_FUNCTION_TYPE)); 2684 __ Branch(is_false, ne, instance_type, Operand(JS_FUNCTION_TYPE));
(...skipping 3431 matching lines...) Expand 10 before | Expand all | Expand 10 after
6106 __ Push(at, ToRegister(instr->function())); 6116 __ Push(at, ToRegister(instr->function()));
6107 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6117 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6108 RecordSafepoint(Safepoint::kNoLazyDeopt); 6118 RecordSafepoint(Safepoint::kNoLazyDeopt);
6109 } 6119 }
6110 6120
6111 6121
6112 #undef __ 6122 #undef __
6113 6123
6114 } // namespace internal 6124 } // namespace internal
6115 } // namespace v8 6125 } // namespace v8
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/mips64/macro-assembler-mips64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698