Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Issue 1306303005: Revert of [es5] Class of object is "Function" if object has [[Call]]. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es5] Class of object is "Function" if object has [[Call]]. (patchset #3 id:40001 of https://codereview.chromium.org/1307943013/ ) Reason for revert: [Sheriff] Changes several layout test expectations. Please fix upstream first if intended. E.g.: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/1729 Several lines change from PASS to FAIL. Original issue's description: > [es5] Class of object is "Function" if object has [[Call]]. > > The concept of class was mostly removed from ES6, but we still use the > class of objects to distinguish object kinds in our builtins. So update > this to be in sync with IsCallable (thereby getting rid of the previous > instance type based tests for callable things completely). > > R=jarin@chromium.org, jkummerow@chromium.org > > Committed: https://crrev.com/af778389947f1b01fb036756ea3cb8ed8ab98452 > Cr-Commit-Position: refs/heads/master@{#30566} TBR=jarin@chromium.org,jkummerow@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c340548979e51cb0bd5d8021165b1becc5875507 Cr-Commit-Position: refs/heads/master@{#30568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -198 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +26 lines, -14 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +20 lines, -14 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +26 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +18 lines, -11 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +17 lines, -11 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +39 lines, -31 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +17 lines, -11 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +16 lines, -10 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +39 lines, -32 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +25 lines, -12 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +22 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +23 lines, -13 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +23 lines, -13 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +25 lines, -13 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [es5] Class of object is "Function" if object has [[Call]].
5 years, 3 months ago (2015-09-03 15:02:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306303005/1
5 years, 3 months ago (2015-09-03 15:02:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 15:02:41 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 15:03:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c340548979e51cb0bd5d8021165b1becc5875507
Cr-Commit-Position: refs/heads/master@{#30568}

Powered by Google App Engine
This is Rietveld 408576698