src/x87/code-stubs-x87.cc - Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/code-stubs-x87.cc

Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Michis comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x87/code-stubs-x87.cc

diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc

index aa57534844088b3994b40402f4983206aaec445b..ff05f4d763af4032802c1d7977e29d4841152534 100644

--- a/src/x87/code-stubs-x87.cc

+++ b/src/x87/code-stubs-x87.cc

@@ -2981,7 +2981,7 @@ void ToNumberStub::Generate(MacroAssembler* masm) {

__ pop(ecx); // Pop return address.

__ push(eax); // Push argument.

__ push(ecx); // Push return address.

- __ InvokeBuiltin(Context::TO_NUMBER_BUILTIN_INDEX, JUMP_FUNCTION);

+ __ TailCallRuntime(Runtime::kToNumber, 1, 1);

}

« src/objects.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »