src/full-codegen/arm64/full-codegen-arm64.cc - Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Michis comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/arm64/full-codegen-arm64.cc

diff --git a/src/full-codegen/arm64/full-codegen-arm64.cc b/src/full-codegen/arm64/full-codegen-arm64.cc

index a9ec2aa3bfb9d09bc80a82c97cccc2f4ff0e9533..55ac3f5f9185b52e23d46e75460d66546e2aa0db 100644

--- a/src/full-codegen/arm64/full-codegen-arm64.cc

+++ b/src/full-codegen/arm64/full-codegen-arm64.cc

@@ -3169,7 +3169,7 @@ void FullCodeGenerator::EmitIsStringWrapperSafeForDefaultValueOf(

// string "valueOf" the result is false.

int descriptor_size = DescriptorArray::kDescriptorSize * kPointerSize;

- __ Mov(valueof_string, Operand(isolate()->factory()->value_of_string()));

+ __ LoadRoot(valueof_string, Heap::kvalueOf_stringRootIndex);

__ Bind(&loop);

__ Ldr(x15, MemOperand(descriptors, descriptor_size, PostIndex));

__ Cmp(x15, valueof_string);

« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | src/objects.cc » ('J')