Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: src/execution.cc

Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Michis comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/execution.cc
diff --git a/src/execution.cc b/src/execution.cc
index 4ab2403e56f0a0cc9d9345e51e0a233a260ff21c..64e5e39f9aa13471c675482bbf22220ada71b292 100644
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -544,18 +544,6 @@ void StackGuard::InitThread(const ExecutionAccess& lock) {
} while (false)
-MaybeHandle<Object> Execution::ToNumber(
- Isolate* isolate, Handle<Object> obj) {
- RETURN_NATIVE_CALL(to_number, { obj });
-}
-
-
-MaybeHandle<Object> Execution::ToString(
- Isolate* isolate, Handle<Object> obj) {
- RETURN_NATIVE_CALL(to_string, { obj });
-}
-
-
MaybeHandle<Object> Execution::ToDetailString(
Isolate* isolate, Handle<Object> obj) {
RETURN_NATIVE_CALL(to_detail_string, { obj });
@@ -584,7 +572,7 @@ MaybeHandle<Object> Execution::NewDate(Isolate* isolate, double time) {
MaybeHandle<Object> Execution::ToInt32(Isolate* isolate, Handle<Object> obj) {
- ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Execution::ToNumber(isolate, obj),
+ ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Object::ToNumber(isolate, obj),
Object);
return isolate->factory()->NewNumberFromInt(DoubleToInt32(obj->Number()));
}
@@ -601,7 +589,7 @@ MaybeHandle<Object> Execution::ToObject(Isolate* isolate, Handle<Object> obj) {
MaybeHandle<Object> Execution::ToUint32(Isolate* isolate, Handle<Object> obj) {
- ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Execution::ToNumber(isolate, obj),
+ ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Object::ToNumber(isolate, obj),
Object);
return isolate->factory()->NewNumberFromUint(DoubleToUint32(obj->Number()));
}
« no previous file with comments | « src/execution.h ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698