Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/cctest/test-heap.cc

Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Michis comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 SIMD128_TYPES(SIMD128_TYPE) 67 SIMD128_TYPES(SIMD128_TYPE)
68 #undef SIMD128_TYPE 68 #undef SIMD128_TYPE
69 CheckMap(heap->fixed_array_map(), FIXED_ARRAY_TYPE, kVariableSizeSentinel); 69 CheckMap(heap->fixed_array_map(), FIXED_ARRAY_TYPE, kVariableSizeSentinel);
70 CheckMap(heap->string_map(), STRING_TYPE, kVariableSizeSentinel); 70 CheckMap(heap->string_map(), STRING_TYPE, kVariableSizeSentinel);
71 } 71 }
72 72
73 73
74 static void CheckOddball(Isolate* isolate, Object* obj, const char* string) { 74 static void CheckOddball(Isolate* isolate, Object* obj, const char* string) {
75 CHECK(obj->IsOddball()); 75 CHECK(obj->IsOddball());
76 Handle<Object> handle(obj, isolate); 76 Handle<Object> handle(obj, isolate);
77 Object* print_string = 77 Object* print_string = *Object::ToString(isolate, handle).ToHandleChecked();
78 *Execution::ToString(isolate, handle).ToHandleChecked();
79 CHECK(String::cast(print_string)->IsUtf8EqualTo(CStrVector(string))); 78 CHECK(String::cast(print_string)->IsUtf8EqualTo(CStrVector(string)));
80 } 79 }
81 80
82 81
83 static void CheckSmi(Isolate* isolate, int value, const char* string) { 82 static void CheckSmi(Isolate* isolate, int value, const char* string) {
84 Handle<Object> handle(Smi::FromInt(value), isolate); 83 Handle<Object> handle(Smi::FromInt(value), isolate);
85 Object* print_string = 84 Object* print_string = *Object::ToString(isolate, handle).ToHandleChecked();
86 *Execution::ToString(isolate, handle).ToHandleChecked();
87 CHECK(String::cast(print_string)->IsUtf8EqualTo(CStrVector(string))); 85 CHECK(String::cast(print_string)->IsUtf8EqualTo(CStrVector(string)));
88 } 86 }
89 87
90 88
91 static void CheckNumber(Isolate* isolate, double value, const char* string) { 89 static void CheckNumber(Isolate* isolate, double value, const char* string) {
92 Handle<Object> number = isolate->factory()->NewNumber(value); 90 Handle<Object> number = isolate->factory()->NewNumber(value);
93 CHECK(number->IsNumber()); 91 CHECK(number->IsNumber());
94 Handle<Object> print_string = 92 Handle<Object> print_string =
95 Execution::ToString(isolate, number).ToHandleChecked(); 93 Object::ToString(isolate, number).ToHandleChecked();
96 CHECK(String::cast(*print_string)->IsUtf8EqualTo(CStrVector(string))); 94 CHECK(String::cast(*print_string)->IsUtf8EqualTo(CStrVector(string)));
97 } 95 }
98 96
99 97
100 static void CheckFindCodeObject(Isolate* isolate) { 98 static void CheckFindCodeObject(Isolate* isolate) {
101 // Test FindCodeObject 99 // Test FindCodeObject
102 #define __ assm. 100 #define __ assm.
103 101
104 Assembler assm(isolate, NULL, 0); 102 Assembler assm(isolate, NULL, 0);
105 103
(...skipping 6554 matching lines...) Expand 10 before | Expand all | Expand 10 after
6660 { 6658 {
6661 SharedFunctionInfo::Iterator iterator(isolate); 6659 SharedFunctionInfo::Iterator iterator(isolate);
6662 while (iterator.Next()) sfi_count--; 6660 while (iterator.Next()) sfi_count--;
6663 } 6661 }
6664 6662
6665 CHECK_EQ(0, sfi_count); 6663 CHECK_EQ(0, sfi_count);
6666 } 6664 }
6667 6665
6668 } // namespace internal 6666 } // namespace internal
6669 } // namespace v8 6667 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698