Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/messages.cc

Issue 1306303003: [es6] Implement spec compliant ToPrimitive in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Michis comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/messages.h" 5 #include "src/messages.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/execution.h" 8 #include "src/execution.h"
9 #include "src/string-builder.h" 9 #include "src/string-builder.h"
10 10
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 464
465 MaybeHandle<String> ErrorToStringHelper::GetStringifiedProperty( 465 MaybeHandle<String> ErrorToStringHelper::GetStringifiedProperty(
466 Isolate* isolate, LookupIterator* property_lookup, 466 Isolate* isolate, LookupIterator* property_lookup,
467 Handle<String> default_value) { 467 Handle<String> default_value) {
468 if (!property_lookup->IsFound()) return default_value; 468 if (!property_lookup->IsFound()) return default_value;
469 Handle<Object> obj; 469 Handle<Object> obj;
470 ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Object::GetProperty(property_lookup), 470 ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Object::GetProperty(property_lookup),
471 String); 471 String);
472 if (obj->IsUndefined()) return default_value; 472 if (obj->IsUndefined()) return default_value;
473 if (!obj->IsString()) { 473 if (!obj->IsString()) {
474 ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Execution::ToString(isolate, obj), 474 ASSIGN_RETURN_ON_EXCEPTION(isolate, obj, Object::ToString(isolate, obj),
475 String); 475 String);
476 } 476 }
477 return Handle<String>::cast(obj); 477 return Handle<String>::cast(obj);
478 } 478 }
479 479
480 } // namespace internal 480 } // namespace internal
481 } // namespace v8 481 } // namespace v8
OLDNEW
« no previous file with comments | « src/messages.h ('k') | src/mips/code-stubs-mips.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698