Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13063004: Method to get Media Galleries handlers in MediaGalleriesPrivateApi. (Closed)

Created:
7 years, 9 months ago by mtomasz
Modified:
7 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Method to get Media Galleries handlers in MediaGalleriesPrivateApi. For the gatekeeper, we need list of media galleries handlers to know what to display in the action choice dialog. This patch adds a method whih returns such lists via a asynchronous call to chrome.mediaGalleriesPrivate.getHandlers. TEST=Tested manually. Not in production, yet. BUG=222565 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190556

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 4

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1 line) Patch
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 1 2 2 chunks +52 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/media_galleries_private.idl View 1 2 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@benwells: PTAL. This is super urgent, for M27 (Pri-1). Thanks.
7 years, 9 months ago (2013-03-25 13:25:05 UTC) #1
benwells
lgtm with nits https://codereview.chromium.org/13063004/diff/3001/chrome/common/extensions/api/media_galleries_private.idl File chrome/common/extensions/api/media_galleries_private.idl (right): https://codereview.chromium.org/13063004/diff/3001/chrome/common/extensions/api/media_galleries_private.idl#newcode66 chrome/common/extensions/api/media_galleries_private.idl:66: // A dictionary that describes a ...
7 years, 9 months ago (2013-03-25 17:55:03 UTC) #2
benwells
lgtm with nits https://codereview.chromium.org/13063004/diff/3001/chrome/common/extensions/api/media_galleries_private.idl File chrome/common/extensions/api/media_galleries_private.idl (right): https://codereview.chromium.org/13063004/diff/3001/chrome/common/extensions/api/media_galleries_private.idl#newcode66 chrome/common/extensions/api/media_galleries_private.idl:66: // A dictionary that describes a ...
7 years, 9 months ago (2013-03-25 17:55:03 UTC) #3
mtomasz
https://codereview.chromium.org/13063004/diff/3001/chrome/common/extensions/api/media_galleries_private.idl File chrome/common/extensions/api/media_galleries_private.idl (right): https://codereview.chromium.org/13063004/diff/3001/chrome/common/extensions/api/media_galleries_private.idl#newcode66 chrome/common/extensions/api/media_galleries_private.idl:66: // A dictionary that describes a media galleries handlers. ...
7 years, 9 months ago (2013-03-26 01:47:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13063004/7001
7 years, 9 months ago (2013-03-26 01:50:07 UTC) #5
mtomasz
7 years, 9 months ago (2013-03-26 04:23:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r190556 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698