Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: Source/core/css/CSSImageValue.cpp

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSImageValue.h ('k') | Source/core/css/CSSMarkup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSImageValue.cpp
diff --git a/Source/core/css/CSSImageValue.cpp b/Source/core/css/CSSImageValue.cpp
index 8be299fbac042f8635fb779080bdf87b7027f4f8..1436a1dbdc38cd4422390575538e4b82d96207b8 100644
--- a/Source/core/css/CSSImageValue.cpp
+++ b/Source/core/css/CSSImageValue.cpp
@@ -108,7 +108,8 @@ bool CSSImageValue::equals(const CSSImageValue& other) const
String CSSImageValue::customCSSText() const
{
- return "url(" + quoteCSSURLIfNeeded(m_absoluteURL) + ")";
+ // TODO(nainar): Serialise with quotation marks to match spec: https://drafts.csswg.org/cssom/#serialize-a-url
+ return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relativeURL)) + ")";
}
bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const
« no previous file with comments | « Source/core/css/CSSImageValue.h ('k') | Source/core/css/CSSMarkup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698