Source/core/css/CSSImageValue.cpp - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSImageValue.cpp

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: As per feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSImageValue.cpp

diff --git a/Source/core/css/CSSImageValue.cpp b/Source/core/css/CSSImageValue.cpp

index 8be299fbac042f8635fb779080bdf87b7027f4f8..38d4edb99e655640722d1027202d2a448e910bb3 100644

--- a/Source/core/css/CSSImageValue.cpp

+++ b/Source/core/css/CSSImageValue.cpp

@@ -108,7 +108,8 @@ bool CSSImageValue::equals(const CSSImageValue& other) const

String CSSImageValue::customCSSText() const

{

- return "url(" + quoteCSSURLIfNeeded(m_absoluteURL) + ")";

+ // TODO(nainar): Serialise with quotation marks to match spec: https://drafts.csswg.org/cssom/#serialize-a-string

+ return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relativeURL)) + ")";

}

bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const

« LayoutTests/fast/css/getComputedStyle-relativeURL.html ('K') | « Source/core/css/CSSImageValue.h ('k') | Source/core/css/CSSMarkup.h » ('j') | no next file with comments »