Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: Source/core/css/CSSImageValue.cpp

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSImageValue.cpp
diff --git a/Source/core/css/CSSImageValue.cpp b/Source/core/css/CSSImageValue.cpp
index 8be299fbac042f8635fb779080bdf87b7027f4f8..ce3c83c68259e5ef92933fd20cec4f59a902f4a8 100644
--- a/Source/core/css/CSSImageValue.cpp
+++ b/Source/core/css/CSSImageValue.cpp
@@ -108,7 +108,11 @@ bool CSSImageValue::equals(const CSSImageValue& other) const
String CSSImageValue::customCSSText() const
{
- return "url(" + quoteCSSURLIfNeeded(m_absoluteURL) + ")";
+ // TODO (nainar): Currently the spec -> https://drafts.csswg.org/cssom/#serialize-a-string
+ // states that the serialized string in the URL should have quotation marks appended on
+ // both ends of the string. However, the layout tests currently do not expect that, hence
+ // we need another patch that fixes that. For now serializing without quotation marks
alancutter (OOO until 2018) 2015/09/18 02:55:09 This should be a one liner. // TODO(nainar): Seria
nainar 2015/09/18 03:47:25 Done.
+ return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relativeURL)) + ")";
}
bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const

Powered by Google App Engine
This is Rietveld 408576698