Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: Source/core/css/CSSCrossfadeValue.cpp

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSCrossfadeValue.cpp
diff --git a/Source/core/css/CSSCrossfadeValue.cpp b/Source/core/css/CSSCrossfadeValue.cpp
index 43536472b972fa8c1adccba67c7ba68eaea491a5..a18ace72e11aa8330dc92e6c404047ca07ee9009 100644
--- a/Source/core/css/CSSCrossfadeValue.cpp
+++ b/Source/core/css/CSSCrossfadeValue.cpp
@@ -117,6 +117,20 @@ String CSSCrossfadeValue::customCSSText() const
return result.toString();
}
+PassRefPtrWillBeRawPtr<CSSCrossfadeValue> CSSCrossfadeValue::valueWithURLMadeAbsolute()
+{
+ if (m_fromValue->isImageValue() && m_toValue->isImageValue()) {
+ return CSSCrossfadeValue::create(toCSSImageValue(*m_fromValue).valueWithURLMadeAbsolute(), toCSSImageValue(*m_toValue).valueWithURLMadeAbsolute(), m_percentageValue);
+ }
+ if (m_fromValue->isImageValue()) {
+ return CSSCrossfadeValue::create(toCSSImageValue(*m_fromValue).valueWithURLMadeAbsolute(), m_toValue, m_percentageValue);
+ }
+ if (m_toValue->isImageValue()) {
+ return CSSCrossfadeValue::create(m_fromValue, toCSSImageValue(*m_toValue).valueWithURLMadeAbsolute(), m_percentageValue);
+ }
+ return this;
alancutter (OOO until 2018) 2015/09/18 02:55:09 This can be simplified if you use temporary variab
nainar 2015/09/18 03:47:25 Done.
+}
+
IntSize CSSCrossfadeValue::fixedSize(const LayoutObject* layoutObject)
{
Image* fromImage = renderableImageForCSSValue(m_fromValue.get(), layoutObject);

Powered by Google App Engine
This is Rietveld 408576698