Source/core/css/CSSImageGeneratorValue.h - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSImageGeneratorValue.h

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSImageGeneratorValue.h

diff --git a/Source/core/css/CSSImageGeneratorValue.h b/Source/core/css/CSSImageGeneratorValue.h

index 91be6277014e8ed599843ad71232f968c0c8efde..272d21a07b67af0dd0041b3e85f48303bc042e1a 100644

--- a/Source/core/css/CSSImageGeneratorValue.h

+++ b/Source/core/css/CSSImageGeneratorValue.h

@@ -68,6 +68,8 @@ public:

void loadSubimages(Document*);

+ PassRefPtrWillBeRawPtr<CSSImageGeneratorValue> valueWithAbsoluteURL();

Timothy Loh 2015/09/15 12:20:47 Maybe valueWithURLsMadeAbsolute / valueWithURLMade

nainar 2015/09/16 07:16:49 Changed name across all to -> valueWithURLMadeAbso

DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor); }

protected:

« Source/core/css/CSSCrossfadeValue.cpp ('K') | « Source/core/css/CSSCrossfadeValue.cpp ('k') | Source/core/css/CSSImageGeneratorValue.cpp » ('j') | Source/core/css/CSSImageValue.cpp » ('J')